Fill out a few small pieces in Variant#7209
Merged
robert3005 merged 2 commits intodevelopfrom Apr 1, 2026
Merged
Conversation
Signed-off-by: Adam Gutglick <adam@spiraldb.com>
AdamGS
force-pushed
the
adamg/fill-some-missed-variant-things
branch
from
f54ac76 to
8267975
Compare
Contributor
Author
|
not sure I can have a very meaningful test here (yet!), happy not to merge this for now or just close it until we have a meaningful variant child. |
Contributor
|
let's just merge it |
lwwmanning
pushed a commit
that referenced
this pull request
Apr 1, 2026
## Summary Just fill out some pieces that I missed in the previous Variant PRs --------- Signed-off-by: Adam Gutglick <adam@spiraldb.com> Signed-off-by: Will Manning <will@willmanning.io>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Just fill out some pieces that I missed in the previous Variant PRs